Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd: reduce use of global conf in the SE
To:
tech@openbsd.org
Date:
Wed, 26 Feb 2025 11:15:15 +0100

Download raw body.

Thread
On Wed, Feb 26, 2025 at 10:56:33AM +0100, Claudio Jeker wrote:
> The session engine has a global conf symbol that contains the bgpd_config.
> This is a easy trap and something I like to change in the long run.
> 
> Here is a diff that that reduces the use of conf by storing some values
> inside the peer (the bgpid and the connectretry time).
> 
> This is from a larger diff I sent out but I decided to move the
> connectretry time to the peer_config so if we want we can have per peer
> connectretry times.

Makes sense. I assume p->connectretry isn't added to peer_print()
because it is not configurable.

ok tb