Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: bgpd: simplify IMSG_CTL_KROUTE
To:
Theo Buehler <tb@theobuehler.org>
Cc:
tech@openbsd.org
Date:
Mon, 8 Jan 2024 16:05:37 +0100

Download raw body.

Thread
On Mon, Jan 08, 2024 at 03:54:42PM +0100, Theo Buehler wrote:
> On Mon, Jan 08, 2024 at 03:43:58PM +0100, Claudio Jeker wrote:
> > This diff replaces the strange encoding of IMSG_CTL_KROUTE with
> > a struct that holds the flags and af field. This will allow to use
> > imsg_get_data() instead (which is the next diff).
> 
> ok.
> 
> I see that it's done throughout the switch: why is imsg_compose() not
> error checked?

No good reason. The control tools are a bit sloppy when it comes to imsg
handling. 

-- 
:wq Claudio