Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: iked: use imsg_get_fd()
To:
tech@openbsd.org
Date:
Tue, 16 Jan 2024 14:32:37 +0100

Download raw body.

Thread
On Tue, Jan 16, 2024 at 02:06:02PM +0100, Claudio Jeker wrote:
> As usual iked is a bit more complicated when it comes to imsg handling.
> 
> Most conversions from imsg->fd to imsg_get_fd(imsg) are simple. Sometimes
> an extra variable is needed or code is shuffled a bit.
> 
> proc_forward_imsg() is never used with an imsg that contains a file
> descriptor. So just pass -1 there. This code could be replaced with
> imsg_forward().
> 
> I added an XXX for some code that will no longer be required once
> imsg_free() closes any unclaimed fd.

ok tb