Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: httpd: imsg_get_fd and fix a use-after-free
To:
tech@openbsd.org
Date:
Tue, 16 Jan 2024 18:08:12 +0100

Download raw body.

Thread
On Tue, Jan 16, 2024 at 05:45:32PM +0100, Claudio Jeker wrote:
> This converts httpd to use imsg_get_fd().
> 
> While there fix a use-after-free on failure in config_getserver().
> The problem is hit when get_data() fails for the variable-length values.
> Shuffling the code a bit to insert the srv onto the lists later fixes the
> problem.

Right. Please commit this separately.

> Also do the same no-fd passing change in proc_forward_imsg() as done in
> iked. Again nothing needs this so neuter this miss-feature.

ok