Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: snmpd [0/4]: MIB parsing support
To:
Martijn van Duren <openbsd+tech@list.imperialat.at>
Cc:
tech@openbsd.org
Date:
Thu, 18 Jan 2024 13:32:22 +0100

Download raw body.

Thread
On Fri, Dec 29, 2023 at 04:47:34PM +0100, Martijn van Duren wrote:
> tl;dr implications which need consideration:
> - slower start-up time
> - extra memory usage
> - extra files in /usr/share/snmp/mibs
> - Permissions to ship particular MIBs.

I do not have the spare cycles to perform a meaningful review of two
thousand lines of code implementing a standard I'm not particularly
familiar with (and don't really want to be). That it is yacc makes me
even less suitable for reviewing this.

I also do not know if there is a better way of handling two .y files in
the Makefile. I'm not particularly offended.

If no one raises concerns about your 4 points above or the makefile
changes, I would say: it's your code, you are our snmp maintainer,
you've invested time in thinking about how you want to move forward,
you've done the work, it would be a pity to see it go to waste.

So: unless somebody speaks up in the next few days, I'd say land part 1
and I will then review the other three bits.