On Thu, Jan 25, 2024 at 05:59:25PM +0000, Klemens Nanni wrote:
> How did you test?

1. built bsd.rd and booted intaller from it
2. installed manually with full disk encryption and recorded answers file
3. added new answer with password for encryption to autoinstall file
4. booted again and selected autoinstall
5. after installation booted again and verified system asks
   for disk password and boots

> ask_password() may return the empty string, but bioctl(8) won't accept it.

Ok, I need to make sure non-empty password is required.

> DISK_PASS serves no purpose.

Right. I'll remove it.

> A different interactive prompt is certainly the only effective change.
> 
> Unattended installations won't be able to run this code as you left this
> up in encrypt_root():

Hm... I remember that my autoinstall failed because of it and I had
to rebuild with this line commented out. Then it worked. I can't
remember how I ended up with invalid diff.

Sorry, I'll come up with an updated patch including requested changes.

Thanks for feedback.

Best regards,
Chris Narkiewicz