Index | Thread | Search

From:
Todd C. Miller <millert@openbsd.org>
Subject:
Re: in_pcbnotifyall sockaddr_in
To:
Alexander Bluhm <alexander.bluhm@gmx.net>
Cc:
tech@openbsd.org
Date:
Sun, 28 Jan 2024 10:14:28 -0700

Download raw body.

Thread
On Sun, 28 Jan 2024 15:03:17 +0100, Alexander Bluhm wrote:

> in_pcbnotifyall() is an IPv4 only function.  All callers check that
> sockaddr dst is in fact a sockaddr_in.  Better pass the more spcific
> type and remove the runtime check at beginning of in_pcbnotifyall().
>
> Use const sockaddr_in in in_pcbnotifyall() and const sockaddr_in6
> in6_pcbnotify() for dst parameter.

Makes sense, OK millert@

 - todd