On Sun, Feb 04, 2024 at 12:50:01PM +0000, Klemens Nanni wrote:
> > I'm not sure if it's a good idea to bind bioctl prompt to installer prompt.
> 
> Why (not)?

I think it makes autoinstaller answers file less readable and sort of
ties it to bioctl. Given that answers should be stable, I assume we
woudn't be inclined to change it in the future if there is another
passphrase for something different. Having a clear and to the point
prompt future-proofs it and establishes a pattern for future evolution.

> 'New Passphrase' is known, unique and noone complained thus far, so I'm
> inclined to stick with that.

I guess that it doesn't matter for interactive installation, because
it's obvious from the context and the prompt doesn't have to be
stable.

For answers file - I assume - the bar would be higher.

I've chosen a prompt similar to the root question, which is
informative and to the point. I think any new password or passphrase
prompt in the future would naturally fall into the same pattern:

Password / passphrase for $WHAT?

My reasoning is based on autoinstaller answers readability and
stability, not interactive installation UX.

Of course - your place - your rules. Please let me know what you think
about this way of thinking.

> You need print not echo, as mentioned before:

Makes sense to me. I'll change it.

> > +		# Ask for password and store it into a temporary file for bioctl
> 
> Passphrase not password, period is missing... I'd just drop the comment.

This comment will go - it's pointless. I think I forgot to remove it.

> Contrary to bigger pick_keydisk() with multiple returns, the new passfile code
> is simple enough to be inlined here, imho.

Ok, I'll inline it.

Best regards,
Chris Narkiewicz