On Mon, Feb 05, 2024 at 01:02:36PM +0100, Clemens Gößnitzer wrote:
> On Mon, 2024-02-05 at 10:03 +0100, Claudio Jeker wrote:
> > On Mon, Feb 05, 2024 at 09:57:26AM +0100, Clemens Gößnitzer wrote:
> > > On Sun, 2024-02-04 at 15:24 -0700, Anthony J. Bentley wrote:
> > > > Clemens Gößnitzer writes:
> > > > > The attached diff modernizes the html output from bgplg(8):
> > > > > 
> > > > > * Switch to html 5
> > > > > * Unify usage of " vs ' in html tags
> > > > > * Drop trailing / for single tags, type=text/css and <!-- ... -
> > > > > ->
> > > > > for
> > > > > css - not needed in html 5
> > > > > * Move style definitions from bgplg.head to bgplg.css
> > > > 
> > > > I see no point in unifying " vs ', they are entirely equivalent
> > > > in this case, and unlike ', " needs escaping in C strings.
> > > > 
> > > > > * Make screen scaling more friendly for mobile devices
> > > > 
> > > > Can't comment on this one. But I suggest leaving it out for now,
> > > > as unlike the other changes it makes the page render differently.
> > > > 
> > > > Everything else looks good to me.
> > > 
> > > Thank you for your feedback.  Attached, you find a diff that just
> > > converts everything to valid html 5.  I also left out moving the
> > > style
> > > definition from the elements to the css file, since that can be
> > > done by
> > > the admin if he wishes to do so.
> > 
> > I would not include the lang attribute on the html node.
> > While some text on those pages are indeed in english it is not
> > required
> > and the output of bgpctl may include non-english text. This is unlike
> > an
> > article where there is a lot of text.
> > 
> > Apart from that this is OK claudio@
> > 
> > 
> 
> I overlooked that index.html is also old xml.  The attached diff does
> not set lang=en anymore and also switches index.html to valid html 5.
> 

Thanks, I committed this version.

-- 
:wq Claudio