Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd: print full path when neighbor-as check fails
To:
tech@openbsd.org
Date:
Tue, 13 Feb 2024 14:59:50 +0100

Download raw body.

Thread
On Tue, Feb 13, 2024 at 02:52:47PM +0100, Claudio Jeker wrote:
> On Tue, Feb 13, 2024 at 12:52:42PM +0100, Theo Buehler wrote:
> > On Tue, Feb 13, 2024 at 12:42:28PM +0100, Claudio Jeker wrote:
> > > I think it is better to show the full path when the enforce neighbor-as
> > > check is on (which it is by default on ebgp sessions).
> > > At least if it triggers it is easier to identify what is up.
> > 
> > Should this protect against printing NULL since you don't error check
> > aspath_asprint()?
> 
> Indeed. How about this instead?

Yes, that's better. Not sure if a save_errno dance would be worth it.
Either way

ok tb