Index | Thread | Search

From:
Job Snijders <job@openbsd.org>
Subject:
Re: rpki-client: kill struct parse
To:
Theo Buehler <tb@theobuehler.org>
Cc:
tech@openbsd.org
Date:
Sat, 17 Feb 2024 10:04:55 +0000

Download raw body.

Thread
On Fri, Feb 16, 2024 at 06:23:44PM +0100, Theo Buehler wrote:
> We have 8 incompatible struct parse. Job is working on number 9.
> 
> Apart from the struct parse in mft.c, there is always the same info: the
> filename of the product being decoded and the struct holding the info we
> need to retain. This struct makes the code harder to read and it's been
> annoying to call functions from other files. The mostly mechanical diff
> below gets rid of this nonsense.
> 
> In mft.c found_crl is a tiny complication, other than that this is
> completely straightforward. I unwrapped lines where I could.

Thanks, this reads nicer

OK job@