Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: rpki-client: tiny tweaks
To:
tech@openbsd.org
Date:
Wed, 21 Feb 2024 13:07:02 +0100

Download raw body.

Thread
On Wed, Feb 21, 2024 at 12:58:23PM +0100, Claudio Jeker wrote:
> On Wed, Feb 21, 2024 at 12:03:49PM +0100, Theo Buehler wrote:
> > ip_addr_cmp() and tak_read() never existed. Fix indent, group the logx
> > and the time functions together (in main.c get_current_time() was
> > between entity_* functions, which makes no sense), move the X509_TIME_*
> > defines to main.c since they aren't used elsewhere and explain the magic
> > numbers.
> > 
> > This shouldn't conflict with job's spl work.
> 
> OK, maybe drop the extern in the get_current_time() prototype.
> Nothing else uses extern.

Ah yes. I'll also fix the secondary indent of various ip_addr* functions
which I missed.