Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: rpki-client: change SHA256_{Init,Update,Final} to EVP_Digest{Init_ex,Update,Final_ex}
To:
Job Snijders <job@openbsd.org>
Cc:
tech@openbsd.org
Date:
Tue, 27 Feb 2024 22:26:56 +0100

Download raw body.

Thread
On Tue, Feb 27, 2024 at 09:23:37PM +0000, Job Snijders wrote:
> Changing the following to help with future portability.
> 
> SHA256_Init() -> EVP_DigestInit_ex()
> SHA256_Update() -> EVP_DigestUpdate()
> SHA256_Final() -> EVP_DigestFinal_ex()
> 
> Also add EVP_MD_CTX_new() and EVP_MD_CTX_free()

I don't think we should do this. It adds complexity for no benefit.
Also, you now pay the price for allocations.