Index | Thread | Search

From:
jan@openbsd.org
Subject:
Re: disable ix(4) LRO by default on sparc64
To:
tech@openbsd.org
Date:
Thu, 7 Mar 2024 17:25:01 +0100

Download raw body.

Thread
Hi,

As discussed on hackers, we'll disable LRO in ix(4) on sparc64 by
default, to avoid further unknown bugs here.  Thus, the upcoming release
has a more stable ix(4) driver.

ok?

bye,
Jan

Index: dev/pci/if_ix.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/if_ix.c,v
diff -u -p -r1.209 if_ix.c
--- dev/pci/if_ix.c	15 Feb 2024 10:56:53 -0000	1.209
+++ dev/pci/if_ix.c	7 Mar 2024 15:43:48 -0000
@@ -1932,7 +1932,9 @@ ixgbe_setup_interface(struct ix_softc *s
 
 	ifp->if_capabilities |= IFCAP_TSOv4 | IFCAP_TSOv6;
 	if (sc->hw.mac.type != ixgbe_mac_82598EB) {
+#ifndef __sparc64__
 		ifp->if_xflags |= IFXF_LRO;
+#endif
 		ifp->if_capabilities |= IFCAP_LRO;
 	}