Index | Thread | Search

From:
Alexandr Nedvedicky <sashan@fastmail.net>
Subject:
Re: route cache and mpath
To:
Alexander Bluhm <bluhm@openbsd.org>
Cc:
tech@openbsd.org
Date:
Sun, 31 Mar 2024 01:48:32 +0100

Download raw body.

Thread
  • Alexander Bluhm:

    route cache and mpath

    • Alexandr Nedvedicky:

      route cache and mpath

On Tue, Mar 26, 2024 at 08:25:37PM +0100, Alexander Bluhm wrote:
> Hi,
> 
> I would like to recommit the route_mpath() diff that was backed out
> before 7.5 release.  An additional rtisvalid() check has caused
> problems when the interface link was not up.  I just removed that
> and now the diff should not change behavior.
> 
> Combine route_cache() and rtalloc_mpath() in new route_mpath().
> 
> Fill and check the cache and call rtalloc_mpath() together.  Then
> the caller of route_mpath() does not have to care about the uint32_t
> *src pointer and just pass struct in_addr.  All the conversions are
> done inside the functions.
> 
> ok?
> 

    I would say code matches what's described. And yes, it's
    a good time to commit this change. So commit if it's not in already.

OK sashan