On Sun, Apr 07, 2024 at 12:43:15PM +0100, Stuart Henderson wrote:
> On 2024/04/07 11:00, Klemens Nanni wrote:
> > On Sat, Apr 06, 2024 at 05:57:02PM -0600, Theo de Raadt wrote:
> > > I worry about one thing:  I have seen fw_update get stuck.
> > 
> > How does this diff make it worse?  finish_up() order change:
> >  ...
> > -installboot
> >  setup /bsd*
> >  script sysmerge, fw_update, syspatch on first boot
> >  fw_update
> > +installboot
> >  relink
> >  ...
> 
> How about running installboot twice - once where it is now, then again
> after fw_update (maybe only if fw_update found something to update?)

Ought to do it, but looks like a workaround and soon we might depend on
installboot run twice (silently) without knowing it...

Not against it, buttt I prefer getting things in order.

If fw_update hangs are a real problem, they should be fixed;  this isn't
the only place we run fw_update.

> 
> > If it hangs, you ^C and restart the install.
> > Or repair manually, where you must look at code to find out what, anwyway.
> > 
> > Is there more to it I'm missing?
> > 
>