Index | Thread | Search

From:
Alexander Bluhm <bluhm@openbsd.org>
Subject:
Re: snmpd closefrom
To:
Martijn van Duren <openbsd+tech@list.imperialat.at>
Cc:
tech@openbsd.org
Date:
Wed, 17 Apr 2024 14:32:40 +0200

Download raw body.

Thread
On Wed, Apr 17, 2024 at 02:07:29PM +0200, Martijn van Duren wrote:
> However, looking at this code I did notice that I never close the
> libexec/snmpd directory fd. With dup2/closefrom it doesn't need
> closing inside the child.
> 
> martijn@

OK bluhm@

> diff /usr/src/usr.sbin/snmpd
> commit - 9d92eaaa1531d9e3edc987eead5b5918f22a0790
> path + /usr/src/usr.sbin/snmpd
> blob - 60af191fb6f00ff295542f65ed9c733b66038830
> file + snmpd.c
> --- snmpd.c
> +++ snmpd.c
> @@ -389,4 +389,6 @@ snmpd_backend(struct snmpd *env)
>  			continue;
>  		}
>  	}
> +
> +	closedir(dir);
>  }
>