Hi Solene,

seeing that you did not commit this yet...

Jason McIntyre wrote on Tue, Apr 30, 2024 at 03:19:01PM +0100:
> On Tue, Apr 30, 2024 at 02:50:58PM +0200, Solene Rapenne wrote:

>> this diff adds a new check in daily(8) using rcctl ls rogue

I like this.

I don't think it is very uncommon to temporarily enable a service for
testing purposes or for doing some one-time task.  After that, there
is a certain risk of getting distracted and forgetting to disable the
service again.  If that happens on a server, it can be quite inconvenient,
so the heads-up from daily(8) will usually be appreciated.

If, on the other hand, people *really* want a service running,
documenting that in rc.conf.local(8) adds clarity and reduces
the risk of mistakes and misunderstandings.

OK schwarze@

>> maybe wording could be merged better with the current text
>> to avoid repeating rc.conf.local(8) twice.

> i think the natural way to say this would be "and vice versa":
> 
> 	Lists any daemons which are enabled in
> 	.Xr rc.conf.local 8
> 	but which are not actually running
> 	(and vice versa).

I like this concise wording, please use it if possible.

Yours,
  Ingo


>> Index: etc/daily
>> ===================================================================
>> RCS file: /cvs/src/etc/daily,v
>> diff -u -p -r1.97 daily
>> --- etc/daily	3 Mar 2023 16:22:57 -0000	1.97
>> +++ etc/daily	30 Apr 2024 12:49:59 -0000
>> @@ -136,6 +136,9 @@ done
>>  next_part "Services that should be running but aren't:"
>>  rcctl ls failed
>>  
>> +next_part "Services that are running but shouldn't:"
>> +rcctl ls rogue
>> +
>>  next_part "Filesystems which need to be dumped:"
>>  dump w | grep -vB1 ^Dump