Index | Thread | Search

From:
Florian Obser <florian@openbsd.org>
Subject:
Re: dig prototypes with no function
To:
tech@openbsd.org
Date:
Fri, 17 May 2024 15:20:30 +0200

Download raw body.

Thread
OK florian

On 2024-05-17 18:38 +10, Jonathan Gray <jsg@jsg.id.au> wrote:
> Index: dig.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/dig/dig.h,v
> diff -u -p -r1.15 dig.h
> --- dig.h	15 Sep 2020 11:47:42 -0000	1.15
> +++ dig.h	17 May 2024 07:18:21 -0000
> @@ -288,9 +288,6 @@ start_lookup(void);
>  void
>  onrun_callback(isc_task_t *task, isc_event_t *event);
>  
> -int
> -dhmain(int argc, char **argv);
> -
>  void
>  setup_libs(void);
>  
> Index: lib/dns/dst_internal.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/dig/lib/dns/dst_internal.h,v
> diff -u -p -r1.12 dst_internal.h
> --- lib/dns/dst_internal.h	15 Sep 2020 08:15:59 -0000	1.12
> +++ lib/dns/dst_internal.h	17 May 2024 07:19:54 -0000
> @@ -133,7 +133,6 @@ isc_result_t dst__hmacsha384_init(struct
>  isc_result_t dst__hmacsha512_init(struct dst_func **funcp);
>  isc_result_t dst__opensslrsa_init(struct dst_func **funcp,
>  				  unsigned char algorithm);
> -isc_result_t dst__opensslecdsa_init(struct dst_func **funcp);
>  
>  /*%
>   * Destructors
> Index: lib/dns/include/dns/compress.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/dig/lib/dns/include/dns/compress.h,v
> diff -u -p -r1.5 compress.h
> --- lib/dns/include/dns/compress.h	14 Sep 2020 08:40:43 -0000	1.5
> +++ lib/dns/include/dns/compress.h	17 May 2024 08:26:02 -0000
> @@ -174,30 +174,10 @@ dns_decompress_init(dns_decompress_t *dc
>   */
>  
>  void
> -dns_decompress_invalidate(dns_decompress_t *dctx);
> -
> -/*%<
> - *	Invalidates 'dctx'.
> - *
> - *	Requires:
> - *\li		'dctx' to be initialized
> - */
> -
> -void
>  dns_decompress_setmethods(dns_decompress_t *dctx, unsigned int allowed);
>  
>  /*%<
>   *	Sets 'dctx->allowed' to 'allowed'.
> - *
> - *	Requires:
> - *\li		'dctx' to be initialized
> - */
> -
> -dns_decompresstype_t
> -dns_decompress_type(dns_decompress_t *dctx);
> -
> -/*%<
> - *	Returns 'dctx->type'
>   *
>   *	Requires:
>   *\li		'dctx' to be initialized
> Index: lib/dns/include/dns/message.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/dig/lib/dns/include/dns/message.h,v
> diff -u -p -r1.12 message.h
> --- lib/dns/include/dns/message.h	25 Jun 2022 09:40:20 -0000	1.12
> +++ lib/dns/include/dns/message.h	17 May 2024 07:22:28 -0000
> @@ -986,27 +986,6 @@ dns_message_takebuffer(dns_message_t *ms
>   */
>  
>  isc_result_t
> -dns_message_rechecksig(dns_message_t *msg, dns_view_t *view);
> -/*%<
> - * Reset the signature state and then if the message was signed,
> - * verify the message.
> - *
> - * Requires:
> - *
> - *\li	msg is a valid parsed message.
> - *\li	view is a valid view or NULL
> - *
> - * Returns:
> - *
> - *\li	#ISC_R_SUCCESS		- the message was unsigned, or the message
> - *				  was signed correctly.
> - *
> - *\li	#DNS_R_EXPECTEDTSIG	- A TSIG was expected, but not seen
> - *\li	#DNS_R_UNEXPECTEDTSIG	- A TSIG was seen but not expected
> - *\li	#DNS_R_TSIGVERIFYFAILURE - The TSIG failed to verify
> - */
> -
> -isc_result_t
>  dns_message_buildopt(dns_message_t *msg, dns_rdataset_t **opt,
>  		     unsigned int version, uint16_t udpsize,
>  		     unsigned int flags, dns_ednsopt_t *ednsopts, size_t count);
> Index: lib/isc/include/isc/log.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/dig/lib/isc/include/isc/log.h,v
> diff -u -p -r1.8 log.h
> --- lib/isc/include/isc/log.h	14 Sep 2020 08:40:44 -0000	1.8
> +++ lib/isc/include/isc/log.h	17 May 2024 07:25:03 -0000
> @@ -552,28 +552,6 @@ isc_log_wouldlog(isc_log_t *lctx, int le
>   */
>  
>  void
> -isc_log_closefilelogs(isc_log_t *lctx);
> -/*%<
> - * Close all open files used by #ISC_LOG_TOFILE channels.
> - *
> - * Notes:
> - *\li	This function is provided for programs that want to use their own
> - *	log rolling mechanism rather than the one provided internally.
> - *	For example, a program that wanted to keep daily logs would define
> - *	a channel which used #ISC_LOG_ROLLNEVER, then once a day would
> - *	rename the log file and call isc_log_closefilelogs().
> - *
> - *\li	#ISC_LOG_TOFILEDESC channels are unaffected.
> - *
> - * Requires:
> - *\li	lctx is a valid context.
> - *
> - * Ensures:
> - *\li	The open files are closed and will be reopened when they are
> - *	next needed.
> - */
> -
> -void
>  isc_log_setcontext(isc_log_t *lctx);
>  /*%<
>   * Sets the context used by the libisc for logging.
>

-- 
In my defence, I have been left unsupervised.