Index | Thread | Search

From:
jon@elytron.openbsd.amsterdam
Subject:
Re: Couple of style corrections
To:
cjeker@diehard.n-r-g.com
Cc:
jsg@jsg.id.au, tech@openbsd.org
Date:
Tue, 11 Jun 2024 21:12:50 +0000

Download raw body.

Thread
Ok, I'll be more careful when pointing out these things. Would you
be so kind as to tell me a couple of things?

1. I am aware that there are a few generated files like ukbd.h and
such. At which point of the build process are they generated? I
would guess at make config. Could you point me to the script that
does the job please?

2. After a closer inspection in sys/conf.h, I see there is a big
mixup of tabs and spaces after #define, in the large #define cdev_*
block. No one cares about this? I thought I would point it out,
maybe you would want to make it more consistent. I fully agree that
is such a minor thing compared to other stuff, just thought that,
since I was lurking there and noticed, I might let people know.
There are actually quite a few more than the ones I pointed out.

Best