Index | Thread | Search

From:
Florian Obser <florian@openbsd.org>
Subject:
Re: Revert "Make daily(8) reporting services that are running"
To:
Bjorn Ketelaars <bket@openbsd.org>
Cc:
tech@openbsd.org, solene@openbsd.org, schwarze@openbsd.org
Date:
Wed, 03 Jul 2024 19:58:34 +0200

Download raw body.

Thread

On 2024-07-03 19:54 +02, Bjorn Ketelaars <bket@openbsd.org> wrote:
> daily(8) reports services that are running but not enabled in
> rc.conf.local(8) by using 'rcctl ls rogue'. The latter does not play
> nice with meta rc-scripts causing falsely identified rogue services to
> appear in daily mails.
>
> The real issue is that the rc.subr framework wasn't developed for meta
> rc-scripts. That said, some of the meta rc-scripts do provide
> information on in which order daemons should be started/stopped in. So
> far, i have been unable to find a fix for this.
>
> Proposal is to revert rogue reporting from daily(8) until a fix for
> rcctl has been found. This will fix daily(8) mails with false
> information.

I think it would be neat to have, but if it's causing too much grieve
your proposal makes sense. OK florian

>
> OK?
>
>
> diff --git etc/daily etc/daily
> index 5463c72fc67..65fb4e344b0 100644
> --- etc/daily
> +++ etc/daily
> @@ -136,9 +136,6 @@ done
>  next_part "Services that should be running but aren't:"
>  rcctl ls failed
>  
> -next_part "Services that are running but shouldn't:"
> -rcctl ls rogue
> -
>  next_part "Filesystems which need to be dumped:"
>  dump w | grep -vB1 ^Dump
>  
> diff --git share/man/man8/daily.8 share/man/man8/daily.8
> index 20743edc7f1..efbe62454f0 100644
> --- share/man/man8/daily.8
> +++ share/man/man8/daily.8
> @@ -112,7 +112,7 @@ for the mount options, e.g.
>  Checks daemon status.
>  Lists any daemons which are enabled in
>  .Xr rc.conf.local 8
> -but which are not actually running (and vice versa).
> +but which are not actually running.
>  .It
>  Reports on which file systems need to be dumped via
>  .Xr dump 8 .

-- 
In my defence, I have been left unsupervised.