Index | Thread | Search

From:
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject:
Re: remove arm64 ampintc_intr_string()
To:
Jonathan Gray <jsg@jsg.id.au>
Cc:
tech@openbsd.org
Date:
Sat, 06 Jul 2024 11:09:38 +0200

Download raw body.

Thread
> Date: Sat, 6 Jul 2024 17:46:42 +1000
> From: Jonathan Gray <jsg@jsg.id.au>
> 
> armv7 ampintc uses ampintc_intr_string(), unused on arm64

ok kettenis@
> 
> diff --git sys/arch/arm64/dev/ampintc.c sys/arch/arm64/dev/ampintc.c
> index 3c0ccb8ed47..ec8c9f3afa9 100644
> --- sys/arch/arm64/dev/ampintc.c
> +++ sys/arch/arm64/dev/ampintc.c
> @@ -185,7 +185,6 @@ void		*ampintc_intr_establish_fdt(void *, int *, int,
>  		    struct cpu_info *, int (*)(void *), void *, char *);
>  void		 ampintc_intr_disestablish(void *);
>  void		 ampintc_irq_handler(void *);
> -const char	*ampintc_intr_string(void *);
>  uint32_t	 ampintc_iack(void);
>  void		 ampintc_eoi(uint32_t);
>  void		 ampintc_set_priority(int, int);
> @@ -897,16 +896,6 @@ ampintc_intr_disestablish(void *cookie)
>  	free(ih, M_DEVBUF, sizeof(*ih));
>  }
>  
> -const char *
> -ampintc_intr_string(void *cookie)
> -{
> -	struct intrhand *ih = (struct intrhand *)cookie;
> -	static char irqstr[1 + sizeof("ampintc irq ") + 4];
> -
> -	snprintf(irqstr, sizeof irqstr, "ampintc irq %d", ih->ih_irq);
> -	return irqstr;
> -}
> -
>  /*
>   * GICv2m frame controller for MSI interrupts.
>   */
> 
>