Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
fix ddb x86 disasm of fucompp
To:
tech@openbsd.org
Date:
Sun, 7 Jul 2024 15:43:17 +1000

Download raw body.

Thread
when merging changes from FreeBSD in i386 rev 1.10
db_Esca5 was added but not used

Index: sys/arch/i386/i386/db_disasm.c
===================================================================
RCS file: /cvs/src/sys/arch/i386/i386/db_disasm.c,v
diff -u -p -r1.24 db_disasm.c
--- sys/arch/i386/i386/db_disasm.c	11 Sep 2020 09:27:10 -0000	1.24
+++ sys/arch/i386/i386/db_disasm.c	7 Jul 2024 05:17:46 -0000
@@ -410,8 +410,8 @@ struct finst db_Esca[] = {
 /*1*/	{ "fimul",  LONG,  0,		0 },
 /*2*/	{ "ficom",  LONG,  0,		0 },
 /*3*/	{ "ficomp", LONG,  0,		0 },
-/*4*/	{ "fisub",  LONG,  op1(X),	0 },
-/*5*/	{ "fisubr", LONG,  0,		0 },
+/*4*/	{ "fisub",  LONG,  0,		0 },
+/*5*/	{ "fisubr", LONG,  op1(X),	db_Esca5 },
 /*6*/	{ "fidiv",  LONG,  0,		0 },
 /*7*/	{ "fidivr", LONG,  0,		0 }
 };
Index: sys/arch/amd64/amd64/db_disasm.c
===================================================================
RCS file: /cvs/src/sys/arch/amd64/amd64/db_disasm.c,v
diff -u -p -r1.25 db_disasm.c
--- sys/arch/amd64/amd64/db_disasm.c	6 Jun 2024 12:36:41 -0000	1.25
+++ sys/arch/amd64/amd64/db_disasm.c	7 Jul 2024 05:15:25 -0000
@@ -409,8 +409,8 @@ struct finst db_Esca[] = {
 /*1*/	{ "fimul",  LONG,  0,		0 },
 /*2*/	{ "ficom",  LONG,  0,		0 },
 /*3*/	{ "ficomp", LONG,  0,		0 },
-/*4*/	{ "fisub",  LONG,  op1(X),	0 },
-/*5*/	{ "fisubr", LONG,  0,		0 },
+/*4*/	{ "fisub",  LONG,  0,		0 },
+/*5*/	{ "fisubr", LONG,  op1(X),	db_Esca5 },
 /*6*/	{ "fidiv",  LONG,  0,		0 },
 /*7*/	{ "fidivr", LONG,  0,		0 }
 };