Index | Thread | Search

From:
"Theo de Raadt" <deraadt@openbsd.org>
Subject:
Re: ip_gre.c conditional compile
To:
Alexander Bluhm <bluhm@openbsd.org>
Cc:
tech@openbsd.org
Date:
Sat, 13 Jul 2024 05:17:01 -0600

Download raw body.

Thread
Sure, that looks correct.

> Todd C. Miller <Todd.Miller@sudo.ws> wrote:
> 
> > On Fri, 12 Jul 2024 13:38:24 -0600, "Theo de Raadt" wrote:
> > 
> > > ed(1) has a horrible signal race.  I annotated it ages ago, but never
> > > figured out how out how to solve it.
> > >
> > > I now realize it can probably be handled in the main loop, but not quite
> > > where I thought.
> > 
> > This looks good to me.  There's no guarantee we'll get the SIGHUP
> > while reading, but ed will call get_tty_line() as part of its event
> > loop and the signal will be handled in there.
> 
> I am also still calling handle_hup() in the SPL0() macro.
> 
> All my tests show that it works if I remove it.
>