Index | Thread | Search

From:
"Theo de Raadt" <deraadt@openbsd.org>
Subject:
Re: env: -u name
To:
Klemens Nanni <kn@openbsd.org>
Cc:
Theo Buehler <tb@theobuehler.org>, tech@openbsd.org
Date:
Sun, 28 Jul 2024 15:54:11 -0600

Download raw body.

Thread
  • Theo Buehler:

    env: -u name

    • Klemens Nanni:

      env: -u name

      • Theo de Raadt:

        env: -u name

So that didn't pass a snapshot build.
Because it broke the snapshot building.

We don't have regression tests for everything.  However, snapshot build
is a very good regression testing, and a highly-available process for
everyone.

So: Your process is lacking.

Klemens Nanni <kn@openbsd.org> wrote:

> 29.07.2024 00:18, Theo Buehler пишет:
> >> Feedback? Objection? OK?
> > 
> >> -	while ((ch = getopt(argc, argv, "i-")) != -1)
> >> +	while ((ch = getopt(argc, argv, "-iu:")) != -1)
> > 
> > Having - in the first position of opstring is special. This breaks
> > setting environment variables.
> > 
> > $ env FOO=foo
> > usage: env [-i] [-u name] [name=value ...] [utility [argument ...]]
> > 
> > Could someone please revert or fix this?
> 
> Oops, fixed, thanks.
>