On Fri, Aug 09, 2024 at 09:51:54PM +0000, Jan Schreiber wrote:
> Hi,
> 
> this diff helps to correctly identify the last unknown devices (AMD and
> SandDisk) from my dmesg output posted here:
> 
> https://dmesgd.nycbug.org/index.cgi?do=view&id=7850
> 
> I couldn't find a "Non-Essential Controller" in pcidevs, so I came up
> with the _NEC suffix.
> The NVMe device id seems to be used for 3 different things - I tried to reflect
> that.
> 
> jan
> 
> diff --git sys/dev/pci/pcidevs sys/dev/pci/pcidevs
> index 789cedbcbab..be185b89f10 100644
> --- sys/dev/pci/pcidevs
> +++ sys/dev/pci/pcidevs
> @@ -833,6 +833,7 @@ product AMD 19_7X_RC                0x14e8  19h/7xh Root
> Complex product AMD 19_7X_IOMMU                0x14e9  19h/7xh IOMMU
>  product AMD 19_7X_HB           0x14ea  19h/7xh Host
>  product AMD 19_7X_PCIE_1       0x14eb  19h/7xh PCIE
> +product AMD 19_7X_NEC          0x14ec  19h/7xh Non-Essential Controller

The Windows driver calls it "PCI" but it does not show as a ppb:

vendor "AMD", unknown product 0x14ec (class instrumentation unknown subclass 0x00, rev 0x00) at pci5 dev 0 function 0 not configured

And was not documented anywhere I could find.

Where did you find that name?

>  product AMD 19_7X_PCIE_2       0x14ed  19h/7xh PCIE
>  product AMD 19_7X_PCIE_3       0x14ee  19h/7xh PCIE
>  product AMD 19_7X_PCIE_4       0x14ef  19h/7xh PCIE
> @@ -8968,6 +8969,7 @@ product SANDISK WDSXXXG3X0C       0x5006  WD Black NVMe
>  product SANDISK PCSN530                0x5008  PC SN530
>  product SANDISK SN850          0x5011  SN850
>  product SANDISK PCSN740                0x5015  PC SN740
> +product SANDISK PCSN770                0x5017  WD Black SN770/SN740/SN560

a string of "PC SN740" is enough, the driver prints various strings as well

>  
>  /* Sangoma products */
>  product SANGOMA A10X           0x0300  A10x
> 
>