Index | Thread | Search

From:
gilles@poolp.org
Subject:
Re: smtpd: implement the report response for proc-filters too
To:
"Omar Polo" <op@omarpolo.com>, tech@openbsd.org
Date:
Sun, 11 Aug 2024 09:12:58 +0000

Download raw body.

Thread
August 9, 2024 2:23 PM, gilles@poolp.org wrote:

> August 9, 2024 12:52 PM, "Omar Polo" <op@omarpolo.com> wrote:
> 
>> We don't seem to allow proc filters to report, unlike built-in ones. We
>> document the report response thought, so I guess it's just an omission.
>> 
>> I'm attaching a diff that adds the missing bits, I've quickly tried with
>> a hacked version of Gilles' filter-kicker that does a report instead of
>> a disconnect and I can see the report being broadcasted.
>> 
>> This was reported by renegm on github:
>> <https://github.com/OpenSMTPD/OpenSMTPD/issues/1257>
>> 
>> Thoughts/clues?
> 
> Initial clue:
> 
> That was an "I'll implement it for proc filters later" moment that never came.
> 
> diff reads ok but I'd like to read it in context before giving an actual ok,
> I'll try to do it today
> 

ok gilles@