Index | Thread | Search

From:
Crystal Kolipe <kolipe.c@exoticsilicon.com>
Subject:
Re: rge(4): fixup rge_encap() DMA syncs
To:
Patrick Wildt <patrick@blueri.se>
Cc:
kevlo@openbsd.org, dlg@openbsd.org, tech@openbsd.org
Date:
Sun, 11 Aug 2024 15:19:08 -0300

Download raw body.

Thread
On Sat, Aug 10, 2024 at 11:11:35PM +0200, Patrick Wildt wrote:
> Hi,
> 
> a friend of mine has been complaining about watchdog timeouts on RK3588.
> I compared the driver with other ones that are stable, like dwqe(4), and
> found a few differences in behaviour.  One thing I noticed is that the
> DMA syncs on rge_encap() most certainly don't work correctly, because it
> only syncs the *last* descriptor in the chain.
> 
> I think this diff should make sure all TX descs are synced.

I've tested this diff with the following NICs, and see no regressions, (yet):

rge0 at pci2 dev 0 function 0 "Realtek RTL8125" rev 0x04: msi, address
rge0 at pci2 dev 0 function 0 "Realtek RTL8125" rev 0x05: msi, address