Index | Thread | Search

From:
Yuichiro NAITO <naito.yuichiro@gmail.com>
Subject:
lldb: shut up the warning message on quit debugging kernel core file
To:
tech@openbsd.org
Date:
Wed, 21 Aug 2024 15:45:46 +0900

Download raw body.

Thread
While I'm debugging the kernel core file with lldb, lldb warns the following
message on 'quit' command. Note that pressing Ctl-d shows no warning messages.

```
Quitting LLDB will kill one or more processes. Do you really want to proceed: [Y/n]
```

It doesn't make sense to me. I'm not debugging any processes so the lldb won't
kill anything. And while I'm debugging the running kernel with
`lldb /bsd -c /dev/mem`, the 'quit' command also warns the same message but
the lldb won't stop the kernel, just quits normally. The warning message misses
the point.

So the following patch shuts up the warning message.
OK?

diff --git a/gnu/llvm/lldb/source/Plugins/Process/OpenBSDKernel/ProcessOpenBSDKernel.h b/gnu/llvm/lldb/source/Plugins/Process/OpenBSDKernel/ProcessOpenBSDKernel.h
index 64d90a39751..451a5f055c0 100644
--- a/gnu/llvm/lldb/source/Plugins/Process/OpenBSDKernel/ProcessOpenBSDKernel.h
+++ b/gnu/llvm/lldb/source/Plugins/Process/OpenBSDKernel/ProcessOpenBSDKernel.h
@@ -43,6 +43,9 @@ public:
 
   lldb_private::DynamicLoader *GetDynamicLoader() override;
 
+  // Process Queries
+  bool WarnBeforeDetach() const override { return false; }
+
 protected:
   bool DoUpdateThreadList(lldb_private::ThreadList &old_thread_list,
 			  lldb_private::ThreadList &new_thread_list) override;


-- 
Yuichiro NAITO (naito.yuichiro@gmail.com)