Index | Thread | Search

From:
Florian Obser <florian@openbsd.org>
Subject:
Re: inet_aton -> inet_pton conversion: fix error checks
To:
Theo Buehler <tb@theobuehler.org>
Cc:
tech <tech@openbsd.org>
Date:
Thu, 22 Aug 2024 10:18:50 +0200

Download raw body.

Thread
On 2024-08-22 10:08 +02, Theo Buehler <tb@theobuehler.org> wrote:
> Here's a tiny whitespace error introduced in one of them:

Thanks for spotting, clearly my editor is too smart. OK florian

>
> Index: parse.y
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ospfd/parse.y,v
> diff -u -p -r1.105 parse.y
> --- parse.y	21 Aug 2024 15:16:56 -0000	1.105
> +++ parse.y	22 Aug 2024 08:06:02 -0000
> @@ -620,7 +620,7 @@ areaid		: NUMBER {
>  			$$.s_addr = htonl($1);
>  		}
>  		| STRING {
> -		if (inet_pton(AF_INET, $1, &$$) != 1) {
> +			if (inet_pton(AF_INET, $1, &$$) != 1) {
>  				yyerror("error parsing area");
>  				free($1);
>  				YYERROR;
>

-- 
In my defence, I have been left unsupervised.