Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: AMD SEV 3/5: Mention AMD PSP in ccp.4
To:
Hans-Jörg Höxer <Hans-Joerg_Hoexer@genua.de>
Cc:
tech@openbsd.org
Date:
Thu, 29 Aug 2024 12:07:57 +1000

Download raw body.

Thread
On Wed, Aug 28, 2024 at 03:25:25PM +0200, Hans-Jörg Höxer wrote:
> Hi,
> 
> mention that the AMD PSP is access through ccp(4).  And adds my name to
> author section.
> 
> Take care,
> HJ.
> -------------------------------------------------------------------------
> commit 9afc1e08780e065c98492ae8fe4ce93b027fc593
> Author: Hans-Joerg Hoexer <hshoexer@genua.de>
> Date:   Wed Aug 28 12:49:21 2024 +0200
> 
>     ccp(4): mention PSP in ccp.4
> 
> diff --git a/share/man/man4/ccp.4 b/share/man/man4/ccp.4
> index 942312f8bcd..cb4b12bd0e7 100644
> --- a/share/man/man4/ccp.4
> +++ b/share/man/man4/ccp.4
> @@ -33,6 +33,12 @@ The
>  .Nm
>  driver supports feeding output of the random number generator into
>  the kernel entropy pool.
> +.Pp
> +On AMD EPYC processors

this line could be "On amd64" as the ioctls aren't only reachable on EPYC

even SEV doesn't appear to be EPYC only?

cpu0: AMD Ryzen 7 5700G with Radeon Graphics, 3800.00 MHz, 19-50-00, patch 0a50000d
cpu0: cpuid 8000001F eax=1780f<SME,SEV,PFLUSH_MSR,SEVES,REQ64BITHOST,RESTINJ,ALTINJ,DBGSTSW,VTE> edx=1

cpu0: AMD Ryzen 9 5900X 12-Core Processor, 3700.01 MHz, 19-21-02, patch 0a20120e
cpu0: cpuid 8000001F eax=1780f<SME,SEV,PFLUSH_MSR,SEVES,REQ64BITHOST,RESTINJ,ALTINJ,DBGSTSW,VTE> ecx=1fd edx=1

cpu0: AMD Ryzen 5 2400G with Radeon Vega Graphics, 3600.01 MHz, 17-11-00, patch 0810100b
cpu0: cpuid 8000001F eax=f<SME,SEV,PFLUSH_MSR,SEVES> ecx=f

> +.Nm
> +provides
> +.Xr ioctl 2
> +access to the platform security processor (PSP).
>  .Sh SEE ALSO
>  .Xr intro 4 ,
>  .Xr random 4 ,
> @@ -48,3 +54,5 @@ The
>  .Nm
>  driver was written by
>  .An David Gwynne Aq Mt dlg@openbsd.org .
> +PSP support was implemented by
> +.An Hans-Joerg Hoexer Aq Mt hshoexer@genua.de .