Index | Thread | Search

From:
Walter Alejandro Iglesias <wai@roquesor.com>
Subject:
Re: Adding Message-ID to mail(1)
To:
tech@openbsd.org
Date:
Fri, 30 Aug 2024 22:26:32 +0200

Download raw body.

Thread
On Fri, Aug 30, 2024 at 02:23:03AM +0200, Christian Schulte wrote:
> On 29.08.24 08:56, Walter Alejandro Iglesias wrote:
> > On Thu, Aug 29, 2024 at 12:35:50AM +0200, Christian Schulte wrote:
> >> Says the man continuously sending mails to this list without any progress.
> > 
> > On the contrary, I did not stop progressing and taking advantage of all
> > the feeback.  Even yours.  Thank you for your help!
> > 
> 
> For what it's worth. There is a function
> 
> int
> getmailname(char *hostname, size_t len)
> 
> in src/usr.sbin/smtpd/util.c[1] which seems to do what you are looking
> for. It will canonicalize the hostname returned by gethostname(3) only

Take a look to this old version of my patches:

   https://marc.info/?l=openbsd-tech&m=171664153226279&w=2

You'll notice at the end of the diff in the message a little function,
generate_uid(), which I'd cut and pasted from the same
src/usr.sbin/smtpd/util.c file.  So, I'm aware also of getmailname() as
well as the another one required, parse_mailname_file().  I decided to
take another path for *many* resons I won't explain since you won't hear
them.

Anyway, as I told you, all feedback is useful, by pointing me out about
that function you made me realize why someone reacted with a *plonk*
message. ;-)  It's not the first developer to take offense at the
mistaken assumption that I didn't take their work into account.


-- 
Walter