Index | Thread | Search

From:
"Theo de Raadt" <deraadt@openbsd.org>
Subject:
Re: print intel hybrid cpu topology information in dmesg
To:
Miod Vallat <miod@online.fr>
Cc:
Janne Johansson <icepic.dz@gmail.com>, Mark Kettenis <mark.kettenis@xs4all.nl>, David Gwynne <david@gwynne.id.au>, tech@openbsd.org
Date:
Sat, 31 Aug 2024 13:49:50 -0600

Download raw body.

Thread
Miod Vallat <miod@online.fr> wrote:

> > On the other hand, it seems mips64 and octeons print out info on all
> > secondary processors that they got from the primary cpu, so it is
> > literally copying the first processor info to all the secondaries and
> > then printing that one over and over.
> > This patch will shrink the dmesg a bit:
> 
> Well, on Octeon it makes sense as I doubt you can have Octeon setup with
> different cpus. On other mips64 ports maintained outside the tree,
> however, the details may differ as the cpus are not always identical.
> 
> So I'd like a ``&& defined(__octeon__)'' in this diff.

I'd prefer to do nothing.  It is silly use of extra #ifdef.