Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: bgplg: add 2 show rib commands (leaked + error)
To:
Job Snijders <job@openbsd.org>
Cc:
tech@openbsd.org
Date:
Mon, 2 Sep 2024 13:52:26 +0200

Download raw body.

Thread
On Mon, Sep 02, 2024 at 11:27:49AM +0000, Job Snijders wrote:
> Should we add something along these lines?
> 
> show rib error
> show rib leaked
> 
> Index: bgplg.h
> ===================================================================
> RCS file: /cvs/src/usr.bin/bgplg/bgplg.h,v
> diff -u -p -r1.17 bgplg.h
> --- bgplg.h	3 Feb 2023 13:10:57 -0000	1.17
> +++ bgplg.h	2 Sep 2024 11:27:35 -0000
> @@ -71,6 +71,10 @@ struct cmd {
>  	    { BGPCTL, "show","ip", "bgp", "ovs", NULL } },		\
>  	{ "show ip bgp avs", 1, 1, "&lt;state&gt;",			\
>  	    { BGPCTL, "show","ip", "bgp", "avs", NULL } },		\
> +	{ "show rib error", 0, 0, NULL,				\
> +	    { BGPCTL, "show", "rib", "error", NULL } },			\
> +	{ "show rib leaked", 0, 0, NULL,				\
> +	    { BGPCTL, "show", "rib", "leaked", NULL } },		\
>  	{ "show ip bgp memory", 0, 0, NULL,				\
>  	    { BGPCTL, "show", "ip", "bgp", "memory", NULL } },		\
>  	{ "show neighbor", 0, 1, NULL,					\
> 

I think this should be "show ip bgp error" since people liked the cisco
syntax here. You can also switch the others over but I think we should not
mix "show rib" and "show ip bgp" like this.

-- 
:wq Claudio