Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd: more rtr ASPA cleanup
To:
tech@openbsd.org
Date:
Mon, 9 Sep 2024 18:02:25 +0200

Download raw body.

Thread
On Mon, Sep 09, 2024 at 04:44:37PM +0200, Claudio Jeker wrote:
> Cleanup some rtr bits. First of all use reallocarray instead of
> recallocarray. aspa_set_entry() is called frequently and the resize will
> be bad especially since all the data of the array will be set in the
> function.

Yes. This is currently bad.

> Then cleanup some old reminents of previous ASPA drafts and check that the
> ASPA PDU has no provider ASnum in the PDU for withdraws or at least 1
> provider ASnum for the announce case. (No draft-14 still didn't get the
> memo that zero providers for announce is a no no but aspa-profile is very
> clear about that).

Someone's missed may well be someone else's deliberately ignored.

ok tb