Index | Thread | Search

From:
gilles@poolp.org
Subject:
Re: smtpd.conf(5): Add domain-from match option in addition to mail-from
To:
"Christian Schulte" <cs@schulte.it>, tech@openbsd.org
Date:
Tue, 24 Sep 2024 09:29:34 +0000

Download raw body.

Thread
  • gilles@poolp.org:

    smtpd.conf(5): Add domain-from match option in addition to mail-from

  • September 24, 2024 5:51 AM, "Christian Schulte" <cs@schulte.it> wrote:
    
    > Sorry for disturbing you again. This has been discussed on the OpenSMTPD
    > mailing list, where I got pointed to the "correct" direction.
    > 
    > <https://www.mail-archive.com/misc@opensmtpd.org/msg06370.html>
    > 
    > Since I sent a patch to @tech, I somehow feel I should at least send the
    > corrected version here as well. My bad. I should not have sent anything like
    > this here in the first place.
    > 
    > All the diff adds is a domain-from match option modeled after the mail-from
    > match option with the only difference, that the domain-from match option will
    > be backed by a table of service K_DOMAIN instead of K_MAILADDR.
    > 
    
    I was off and slowly catching up.
    
    I haven't read the thread on misc@osmtpd yet and I'll need a couple days before
    I can review your diff in context. However a couple comments:
    
    a- I would rather see 'match from domain [...]' rather than 'domain-from' as we
       already do "match for domain [...]"
    
    b- regardless of that, you can already achieve domain matching with 'mail-from'
       even though it works differently, it still covers that need too:
    
       match from mail-from '@example.com' [...] # restricts to a specific domain
    
    
    
  • gilles@poolp.org:

    smtpd.conf(5): Add domain-from match option in addition to mail-from