Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
remove stdio.h include from resolv.h
To:
tech@openbsd.org
Date:
Sun, 13 Oct 2024 14:55:12 +1100

Download raw body.

Thread
  • Jonathan Gray:

    remove stdio.h include from resolv.h

the use of FILE in resolv.h was removed in

----------------------------
revision 1.20
date: 2015/09/25 23:32:51;  author: guenther;  state: Exp;  lines: +1 -53;  commitid: 6Sqt5EBBE8LeTnNQ;
Trim symbols that aren't part of our new resolver

OK semarie@
----------------------------

add stddef.h to getaddrinfo.c for NULL
add stdio.h to getnameinfo.c for snprintf()

stdio.h was added to rsync/socket.c in rev 1.34 for sscanf() snprintf()

Index: include/resolv.h
===================================================================
RCS file: /cvs/src/include/resolv.h,v
diff -u -p -r1.23 resolv.h
--- include/resolv.h	22 Nov 2021 20:18:27 -0000	1.23
+++ include/resolv.h	13 Oct 2024 02:54:12 -0000
@@ -90,7 +90,6 @@
 
 #include <sys/types.h>
 #include <sys/socket.h>
-#include <stdio.h>
 
 /*
  * Revision information.  This is the release date in YYYYMMDD format.
Index: lib/libc/asr/getaddrinfo.c
===================================================================
RCS file: /cvs/src/lib/libc/asr/getaddrinfo.c,v
diff -u -p -r1.9 getaddrinfo.c
--- lib/libc/asr/getaddrinfo.c	8 Oct 2015 14:08:44 -0000	1.9
+++ lib/libc/asr/getaddrinfo.c	13 Oct 2024 03:04:00 -0000
@@ -23,6 +23,7 @@
 #include <asr.h>
 #include <errno.h>
 #include <resolv.h>
+#include <stddef.h>
 
 int
 getaddrinfo(const char *hostname, const char *servname,
Index: lib/libc/asr/getnameinfo.c
===================================================================
RCS file: /cvs/src/lib/libc/asr/getnameinfo.c,v
diff -u -p -r1.11 getnameinfo.c
--- lib/libc/asr/getnameinfo.c	27 Dec 2022 17:10:06 -0000	1.11
+++ lib/libc/asr/getnameinfo.c	13 Oct 2024 03:05:43 -0000
@@ -26,6 +26,7 @@
 #include <errno.h>
 #include <resolv.h>
 #include <string.h>
+#include <stdio.h>
 
 static size_t asr_print_addr(const struct sockaddr *, char *, size_t);
 static size_t asr_print_port(const struct sockaddr *, const char *, char *, size_t);