Index | Thread | Search

From:
Todd C. Miller <millert@openbsd.org>
Subject:
Re: xinstall: do not overrun filename buffer
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
tech@openbsd.org
Date:
Wed, 16 Oct 2024 13:24:41 -0600

Download raw body.

Thread
On Wed, 16 Oct 2024 21:15:24 +0200, Christian Weisgerber wrote:

> There was a weird failure during a ports build:
>
> install: /usr/obj/ports/unknown-horizons-2019.1/fake-amd64/usr/local/share/un
> known-horizons/content/gfx/atlas//INS@FkRVpXXcoW: Bad address
>
> I was going to write it off as a spurious failure, but tb@ took a look
> at xinstall and noticed that the wrong buffer length was passed to
> strlcat().  Or rather, the conversion to strl*() accidentally used
> the wrong variable.

Oops, my bug.  OK millert@

 - todd