On Sun, 3 Nov 2024 19:26:02 +0100
Jan Klemkow <jan@openbsd.org> wrote:
> On Sun, Oct 27, 2024 at 02:45:55PM GMT, YASUOKA Masahiko wrote:
>> On Thu, 24 Oct 2024 15:06:54 +0900 (JST)
>> YASUOKA Masahiko <yasuoka@openbsd.org> wrote:
>> > On Mon, 02 Sep 2024 13:27:04 +0900 (JST)
>> > YASUOKA Masahiko <yasuoka@openbsd.org> wrote:
>> >> I'm commiting ixv(4) from NAITO Yuichiro.  Almost of the changes can
>> >> be done separately from ix(4), but the diff bellow is the part which
>> >> actually affect ix(4).
>> > 
>> > This is the second step.  This diff will not affect existing ix(4)
>> > because it only changes "mailbox" behavior.  "mailbox" is used only
>> > for primary function or virtual function and our ix(4) doesn't support
>> > either yet.
>> 
>> This is the final step.
> 
> Works for me.  I also tested it with TSO capabilities:
> 	ifp->if_capabilities |= IFCAP_TSOv4 | IFCAP_TSOv6;
> But, this can be added afterwards.

Thank you for the test.  It seems nice.

>> ixv(4) is still disabled on the config.
> 
> I guess we could enable ixv(4) it also by default.  It won't harm any
> other part of the kernel as far as I can see.

Certainly.

> Do you want to keep the style of sys/dev/pci/ixgbe_vf.c as is on
> purpose, or can we adapt it to style(9) like the other files?
> 
> Below is a diff that fixes from lint reports of mandoc(1) for ixv.4.

jmc fixed these.  Thanks

ok?

cvs -d cvs.openbsd.org:/cvs diff -up sys/arch/amd64/conf/GENERIC
Index: sys/arch/amd64/conf/GENERIC
===================================================================
RCS file: /cvs/src/sys/arch/amd64/conf/GENERIC,v
diff -u -p -u -p -r1.527 GENERIC
--- sys/arch/amd64/conf/GENERIC	2 Nov 2024 04:37:20 -0000	1.527
+++ sys/arch/amd64/conf/GENERIC	4 Nov 2024 10:47:29 -0000
@@ -529,7 +529,7 @@ msk*	at mskc?			#  each port of above
 em*	at pci?				# Intel Pro/1000 ethernet
 ixgb*	at pci?				# Intel Pro/10Gb ethernet
 ix*	at pci?				# Intel 82598EB 10Gb ethernet
-#ixv*	at pci?				# Virtual Function of Intel 82599
+ixv*	at pci?				# Virtual Function of Intel 82599
 myx*	at pci?				# Myricom Myri-10G 10Gb ethernet
 oce*	at pci?				# Emulex OneConnect 10Gb ethernet
 txp*	at pci?				# 3com 3CR990