Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: {arm64,octeon}_bus_space.c -> bus_space.c
To:
Mark Kettenis <mark.kettenis@xs4all.nl>
Cc:
tech@openbsd.org
Date:
Wed, 13 Nov 2024 22:06:35 +1100

Download raw body.

Thread
On Tue, Nov 12, 2024 at 02:54:26PM +0100, Mark Kettenis wrote:
> > Date: Tue, 12 Nov 2024 00:43:03 +1100
> > From: Jonathan Gray <jsg@jsg.id.au>
> > 
> > arm64/dev/arm64_bus_space.c -> arm64/arm64/bus_space.c
> > octeon/dev/octeon_bus_space.c -> octeon/octeon/bus_space.c
> > 
> > matches other archs
> 
> I really wish we'd do these things in a mor consistent manner, but I'm
> not sure renaming files is worth the pain while we're still using cvs.

The history is still there.  Include paths can also be annoying:

#if defined(__alpha__)
#include <alpha/pci/pci_machdep.h>
#elif defined(__i386__)
#include <i386/pci/pci_machdep.h>
#else
#include <machine/pci_machdep.h>
#endif

as alpha and i386 don't put bus machdep files in include
eisa/eisa_machdep.h
isa/isa_machdep.h
isa/isapnp_machdep.h
pci/pci_machdep.h

though with most of these the ifdefs are limited to
a single file such as pcivar.h