Index | Thread | Search

From:
Mike Larkin <mlarkin@nested.page>
Subject:
Re: Fix some misleading comments and typos in comments
To:
Christian Schulte <cs@schulte.it>
Cc:
tech@openbsd.org
Date:
Sun, 17 Nov 2024 18:32:39 -0800

Download raw body.

Thread
On Wed, Nov 13, 2024 at 12:14:07PM +0100, Christian Schulte wrote:
> Stumbled upon these while reading sources from back when dinosours ruled the
> world. Sending this just out of a habbit of mine (and to reduce local updates).

committed, thanks.

>
> Index: sys/arch//amd64/stand/libsa/memprobe.c
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/stand/libsa/memprobe.c,v
> retrieving revision 1.19
> diff -u -p -u -r1.19 memprobe.c
> --- sys/arch//amd64/stand/libsa/memprobe.c	28 Jan 2021 18:54:52 -0000	1.19
> +++ sys/arch//amd64/stand/libsa/memprobe.c	13 Nov 2024 11:08:25 -0000
> @@ -100,7 +100,7 @@ bios_E820(bios_memmap_t *mp)
>  /*
>   * BIOS int 15, AX=8800
>   *
> - * Only used if int 15, AX=E801 does not work.
> + * Only used if int 15, AX=E820 does not work.
>   * Machines with this are restricted to 64MB.
>   */
>  static __inline bios_memmap_t *
> Index: sys/arch//amd64/stand/mbr/mbr.S
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/stand/mbr/mbr.S,v
> retrieving revision 1.9
> diff -u -p -u -r1.9 mbr.S
> --- sys/arch//amd64/stand/mbr/mbr.S	2 Sep 2022 07:46:03 -0000	1.9
> +++ sys/arch//amd64/stand/mbr/mbr.S	13 Nov 2024 11:08:25 -0000
> @@ -99,7 +99,7 @@ start:
>
>  	/*
>  	 * We don't need to disable and re-enable interrupts around the
> -	 * the load of ss and sp.
> +	 * load of ss and sp.
>  	 *
>  	 * From 80386 Programmer's Reference Manual:
>  	 * "A MOV into SS inhibits all interrupts until after the execution
> Index: sys/arch//i386/stand/libsa/memprobe.c
> ===================================================================
> RCS file: /cvs/src/sys/arch/i386/stand/libsa/memprobe.c,v
> retrieving revision 1.57
> diff -u -p -u -r1.57 memprobe.c
> --- sys/arch//i386/stand/libsa/memprobe.c	10 Jun 2016 18:36:06 -0000	1.57
> +++ sys/arch//i386/stand/libsa/memprobe.c	13 Nov 2024 11:08:25 -0000
> @@ -100,7 +100,7 @@ bios_E820(bios_memmap_t *mp)
>  /*
>   * BIOS int 15, AX=8800
>   *
> - * Only used if int 15, AX=E801 does not work.
> + * Only used if int 15, AX=E820 does not work.
>   * Machines with this are restricted to 64MB.
>   */
>  static __inline bios_memmap_t *
> Index: sys/arch//i386/stand/mbr/mbr.S
> ===================================================================
> RCS file: /cvs/src/sys/arch/i386/stand/mbr/mbr.S,v
> retrieving revision 1.27
> diff -u -p -u -r1.27 mbr.S
> --- sys/arch//i386/stand/mbr/mbr.S	2 Sep 2022 07:46:03 -0000	1.27
> +++ sys/arch//i386/stand/mbr/mbr.S	13 Nov 2024 11:08:26 -0000
> @@ -99,7 +99,7 @@ start:
>
>  	/*
>  	 * We don't need to disable and re-enable interrupts around the
> -	 * the load of ss and sp.
> +	 * load of ss and sp.
>  	 *
>  	 * From 80386 Programmer's Reference Manual:
>  	 * "A MOV into SS inhibits all interrupts until after the execution
>