On 2024/11/22 19:40, Andrew Hewus Fresh wrote:
> + * Testing changes:
> + *
> + * For testing, fw_update(8) has a special case for when it is named
> + * "fw_update.sh" and "firmware_patterns" exists in the current
> + * directory.  It uses those patterns instead of the default.  If
> + * there is also a file called "dmesg" it will use that instead.
> + *
> + * `make firmware_patterns          && ksh ./fw_update.sh`
> + * `scp other-host:/var/run/dmesg . && ksh ./fw_update.sh`

I don't think firmware_patterns hugely needs anything special, you can
install it on a test machine easily enough.

For using an alternative dmesg (which _is_ useful for testing), special
magic based on the filename seems an awkward way to do it. How about
adding a flag to specify the path to the file containing dmesg instead?
That would allow writing some tests feeding fw_update -l -n with various
dmesg, too.