Index | Thread | Search

From:
Nick Owens <mischief@offblast.org>
Subject:
Re: [PATCH] SK hynix P31 and P41 NVMe add to pcidevs
To:
Bryan Vyhmeister <bryan@bsdjournal.net>
Cc:
tech@openbsd.org
Date:
Sun, 24 Nov 2024 19:31:48 -0800

Download raw body.

Thread
On Sun, Nov 24, 2024 at 10:52 AM Bryan Vyhmeister <bryan@bsdjournal.net> wrote:
>
> On Tue, Nov 19, 2024 at 08:11:29PM -0800, Bryan Vyhmeister wrote:
> > I have some SK hynix Platinum P41 and Gold P31 NVMe SSDs in a few
> > different devices and thought I would add them to pcidevs. Before and
> > after for the P41:
> >
> > nvme0 at pci5 dev 0 function 0 vendor "SK hynix", unknown product 0x1959 rev 0x00: msix, NVMe 1.4
> > nvme0: SHPP41-2000GM, firmware 51060A20, serial SJD1N589123456789
> >
> > nvme0 at pci5 dev 0 function 0 "SK hynix Platinum P41 NVMe" rev 0x00: msix, NVMe 1.4
> > nvme0: SHPP41-2000GM, firmware 51060A20, serial SJD1N589123456789
> >
> > Also here is the Gold P31 NVMe before and after the patch as well:
> >
> > nvme0 at pci3 dev 0 function 0 vendor "SK hynix", unknown product 0x174a
> > rev 0x00: msix, NVMe 1.3
> > nvme0: SHGP31-2000GM, firmware 31060C20, serial AJCBN400123456789
> >
> > nvme0 at pci3 dev 0 function 0 "SK hynix Gold P31 NVMe" rev 0x00: msix,
> > NVMe 1.3
> > nvme0: SHGP31-2000GM, firmware 31060C20, serial AJCBN400123456789
>
> Posting again. Thank you.

works on my machine:

nvme0 at pci4 dev 0 function 0 "SK hynix Platinum P41 NVMe" rev 0x00:
msix, NVMe 1.4
nvme0: SHPP41-2000GM, firmware 51060A20, serial SJB9N470110809816

thanks.

>
> Bryan
>
>
> Index: sys/dev/pci/pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> diff -u -p -u -r1.2094 pcidevs
> --- sys/dev/pci/pcidevs 9 Nov 2024 10:23:06 -0000       1.2094
> +++ sys/dev/pci/pcidevs 20 Nov 2024 03:24:29 -0000
> @@ -9267,6 +9267,8 @@ product SIS 966_HDA               0x7502  966 HD Audio
>  /* SK hynix products */
>  product SKHYNIX BC501          0x1327  BC501
>  product SKHYNIX PC601          0x1627  PC601
> +product SKHYNIX SHGP31         0x174a  Gold P31 NVMe
> +product SKHYNIX SHPP41         0x1959  Platinum P41 NVMe
>  product SKHYNIX BC901          0x1d59  BC901
>
>  /* SMC products */
>