Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
vmd/vioblk: missed break
To:
OpenBSD tech <tech@openbsd.org>
Cc:
Dave Voutila <dv@openbsd.org>
Date:
Wed, 27 Nov 2024 12:55:35 +0100

Download raw body.

Thread
tech@,

Here a trivial diff which added missed break.

Without it I see logs from vmd like this:

        vioblk_notifyq: unsupported vioblk command 8

Ok?

Index: ./usr.sbin/vmd/vioblk.c
===================================================================
RCS file: /home/cvs/src/usr.sbin/vmd/vioblk.c,v
diff -u -p -r1.20 vioblk.c
--- ./usr.sbin/vmd/vioblk.c	21 Nov 2024 13:39:34 -0000	1.20
+++ ./usr.sbin/vmd/vioblk.c	27 Nov 2024 11:51:52 -0000
@@ -369,6 +369,7 @@ vioblk_notifyq(struct vioblk_dev *dev)
 			 * often send this command regardless.
 			 */
 			ds = VIRTIO_BLK_S_UNSUPP;
+			break;
 		default:
 			log_warnx("%s: unsupported vioblk command %d", __func__,
 			    cmd->type);


-- 
wbr, Kirill