Hi Jonathan,

Jonathan Gray wrote on Wed, Dec 11, 2024 at 01:07:29PM +1100:

> "The routines memccpy, memchr, memcmp, memcpy, memset, strchr, strcspn,
> strpbrk, strrchr, strspn, and strtok have been added for compatibility
> with System V."
> Bug Fixes and Changes in 4.3BSD, SMM
> https://bitsavers.org/pdf/usenix/Usenix_BSD_Manuals/4.3_1st_printing_198611/
> https://www.tuhs.org/cgi-bin/utree.pl?file=4.3BSD/usr/src/lib/libc/compat-sys5

From the CSRG Archive CD-ROMs, i can confirm that in the original 4.3 release,
 * lib/libc/Makefile entered the directory compat-sys5 for all targets
 * lib/libc/compat-sys5/ contained *.c files for all the functions
   you are touching here
 * lib/libc/compat-sys5/Makefile used all the files you are touching here

Consequently, OK schwarze@.

Not sure why i missed that when changing these from 4.4 to Tahoe
in July 2011.  Maybe because i only got the CSRG Archive CD-ROMs
in October 2011 (but the sources you cite are also sufficient, and
i definitely had access to TUHS at that point), maybe because
touching 53 files in a single commit was a bit overwhelming.
At least i erred to the side of caution and didn't claim these
functions appeared earlier than they actually did.  :-/

Yours,
  Ingo


> Index: lib/libc/string/memccpy.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/memccpy.3,v
> diff -u -p -r1.13 memccpy.3
> --- lib/libc/string/memccpy.3	11 Sep 2022 06:38:11 -0000	1.13
> +++ lib/libc/string/memccpy.3	11 Dec 2024 01:49:57 -0000
> @@ -78,4 +78,4 @@ The
>  function first appeared in
>  .At V
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/memchr.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/memchr.3,v
> diff -u -p -r1.13 memchr.3
> --- lib/libc/string/memchr.3	11 Sep 2022 06:38:11 -0000	1.13
> +++ lib/libc/string/memchr.3	11 Dec 2024 01:51:16 -0000
> @@ -99,4 +99,4 @@ The
>  function first appeared in
>  .At V
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/memcmp.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/memcmp.3,v
> diff -u -p -r1.10 memcmp.3
> --- lib/libc/string/memcmp.3	11 Sep 2022 06:38:11 -0000	1.10
> +++ lib/libc/string/memcmp.3	11 Dec 2024 01:51:45 -0000
> @@ -83,4 +83,4 @@ The
>  function first appeared in
>  .At V
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/memcpy.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/memcpy.3,v
> diff -u -p -r1.10 memcpy.3
> --- lib/libc/string/memcpy.3	5 Jun 2013 03:39:23 -0000	1.10
> +++ lib/libc/string/memcpy.3	11 Dec 2024 01:52:12 -0000
> @@ -76,4 +76,4 @@ The
>  function first appeared in
>  .At V
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/memset.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/memset.3,v
> diff -u -p -r1.9 memset.3
> --- lib/libc/string/memset.3	11 Sep 2022 06:38:11 -0000	1.9
> +++ lib/libc/string/memset.3	11 Dec 2024 01:52:41 -0000
> @@ -72,4 +72,4 @@ The
>  function first appeared in
>  .At V
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strchr.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strchr.3,v
> diff -u -p -r1.13 strchr.3
> --- lib/libc/string/strchr.3	1 Oct 2018 06:37:37 -0000	1.13
> +++ lib/libc/string/strchr.3	11 Dec 2024 01:53:10 -0000
> @@ -113,4 +113,4 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strcspn.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strcspn.3,v
> diff -u -p -r1.11 strcspn.3
> --- lib/libc/string/strcspn.3	5 Jun 2013 03:39:23 -0000	1.11
> +++ lib/libc/string/strcspn.3	11 Dec 2024 01:53:27 -0000
> @@ -105,4 +105,4 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strpbrk.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strpbrk.3,v
> diff -u -p -r1.10 strpbrk.3
> --- lib/libc/string/strpbrk.3	5 Jun 2013 03:39:23 -0000	1.10
> +++ lib/libc/string/strpbrk.3	11 Dec 2024 01:53:47 -0000
> @@ -77,4 +77,4 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strrchr.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strrchr.3,v
> diff -u -p -r1.12 strrchr.3
> --- lib/libc/string/strrchr.3	1 Oct 2018 06:37:37 -0000	1.12
> +++ lib/libc/string/strrchr.3	11 Dec 2024 01:54:09 -0000
> @@ -115,4 +115,4 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strspn.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strspn.3,v
> diff -u -p -r1.11 strspn.3
> --- lib/libc/string/strspn.3	5 Jun 2013 03:39:23 -0000	1.11
> +++ lib/libc/string/strspn.3	11 Dec 2024 01:54:29 -0000
> @@ -89,4 +89,4 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
> Index: lib/libc/string/strtok.3
> ===================================================================
> RCS file: /cvs/src/lib/libc/string/strtok.3,v
> diff -u -p -r1.23 strtok.3
> --- lib/libc/string/strtok.3	2 Sep 2017 13:56:44 -0000	1.23
> +++ lib/libc/string/strtok.3	11 Dec 2024 01:54:52 -0000
> @@ -149,7 +149,7 @@ The
>  function first appeared in
>  .At III
>  and was reimplemented for
> -.Bx 4.3 Tahoe .
> +.Bx 4.3 .
>  The
>  .Fn strtok_r
>  function first appeared in