On 2024/12/28 20:34, Rane Hebden wrote:
> Jonathan Gray <jsg@jsg.id.au> writes:
> 
> > Removing pci ids is the wrong approach.  Having a match function
> > return higher would be enough.
> 
> I removed them as the #define in question also populates the patterns
> used by fw_update. With the PCI IDs being retained, both the radeon and
> amdgpu firmware would be installed automatically by fw_update for cards
> supported by both drivers. Additionally, I wasn't sure there was benefit to
> retaining the PCI IDs if the driver would not be used for these PCI IDs
> with the patch in place, so erred on the side of removing redundant code
> (redundant in the context of the patch).

installing additional firmware isn't really a problem. and if both are
present (if this change is made), you could switch between the two
drivers by disabling amdgpu via ukc or bsd.re-config.