On Thu, Jan 2, 2025 at 1:08 AM Jonathan Gray <jsg@jsg.id.au> wrote:
>
> On Thu, Jan 02, 2025 at 12:33:20AM -0800, Bryan Vyhmeister wrote:
> > On Sat, Nov 30, 2024 at 08:06:54PM -0800, Bryan Vyhmeister wrote:
> > > On Sun, Nov 24, 2024 at 07:31:48PM -0800, Nick Owens wrote:
> > > > works on my machine:
> > > >
> > > > nvme0 at pci4 dev 0 function 0 "SK hynix Platinum P41 NVMe" rev 0x00:
> > > > msix, NVMe 1.4
> > > > nvme0: SHPP41-2000GM, firmware 51060A20, serial SJB9N470110809816
> > > >
> > > > thanks.
> > >
> > > Thanks for testing the patch. I would like to get this committed if
> > > possible. Thank you.
> >
> > Would it be possible to get this patch committed to pcidevs? Thank you.
> >
> > Bryan
>
> The data from the hardware tends to be more detailed.  pcidevs is used
> in space constrained places such as ramdisks.  So I wonder if we should
> be adding an entry for every model of nvme.

this appears to be a few tens of bytes. what are the space constraints
of the ramdisk that
would prohibit this and other future additions to pcidevs? would it be
best to simply not
have stringified pci device names in ramdisks if space is a concern?

>
> >
> >
> > Index: sys/dev/pci/pcidevs
> > ===================================================================
> > RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> > diff -u -p -r1.2094 pcidevs
> > --- sys/dev/pci/pcidevs       9 Nov 2024 10:23:06 -0000       1.2094
> > +++ sys/dev/pci/pcidevs       2 Jan 2025 08:32:00 -0000
> > @@ -9267,6 +9267,8 @@ product SIS 966_HDA             0x7502  966 HD Audio
> >  /* SK hynix products */
> >  product SKHYNIX BC501                0x1327  BC501
> >  product SKHYNIX PC601                0x1627  PC601
> > +product SKHYNIX SHGP31               0x174a  Gold P31 NVMe
> > +product SKHYNIX SHPP41               0x1959  Platinum P41 NVMe
> >  product SKHYNIX BC901                0x1d59  BC901
> >
> >  /* SMC products */
> >
> >
>