Index | Thread | Search

From:
Alexander Bluhm <bluhm@openbsd.org>
Subject:
Re: route_peeraddr: use memcpy
To:
David Hill <dhill@mindcry.org>
Cc:
tech@openbsd.org
Date:
Thu, 2 Jan 2025 11:28:39 +0100

Download raw body.

Thread
On Thu, Jan 02, 2025 at 12:23:00AM +0000, David Hill wrote:
> route_src is a global defined as
> const struct sockaddr route_src = { 2, PF_ROUTE, };
> 
> memcpy can be used here.

OK bluhm@

> Index: rtsock.c
> ===================================================================
> RCS file: /cvs/src/sys/net/rtsock.c,v
> diff -u -p -r1.375 rtsock.c
> --- rtsock.c	12 Jul 2024 17:20:18 -0000	1.375
> +++ rtsock.c	2 Jan 2025 00:16:29 -0000
> @@ -359,7 +359,7 @@ int
>   route_peeraddr(struct socket *so, struct mbuf *nam)
>   {
>   	/* minimal support, just implement a fake peer address */
> -	bcopy(&route_src, mtod(nam, caddr_t), route_src.sa_len);
> +	memcpy(mtod(nam, caddr_t), &route_src, route_src.sa_len);
>   	nam->m_len = route_src.sa_len;
>   	return (0);
>   }