Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd bump rtr max PDU size to 65535
To:
tech@openbsd.org
Date:
Thu, 9 Jan 2025 10:41:17 +0100

Download raw body.

Thread
On Thu, Jan 09, 2025 at 10:37:41AM +0100, Claudio Jeker wrote:
> There is finally some movement around the maximum PDU size of RTR in IETF.
> It seems that RTR will get a maximum PDU size of 65535 so adjust our code.
> Also IBUF_READ_SIZE no longer matters since the ibuf API now handles
> larger PDUs just fine.

ok

> 
> -- 
> :wq Claudio
> 
> Index: rtr_proto.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpd/rtr_proto.c,v
> diff -u -p -r1.47 rtr_proto.c
> --- rtr_proto.c	26 Nov 2024 13:59:54 -0000	1.47
> +++ rtr_proto.c	9 Jan 2025 09:34:22 -0000
> @@ -42,7 +42,7 @@ struct rtr_header {
>  	uint32_t	length;
>  } __packed;
>  
> -#define RTR_MAX_PDU_SIZE	49152	/* XXX < IBUF_READ_SIZE */
> +#define RTR_MAX_PDU_SIZE	65535
>  #define RTR_MAX_PDU_ERROR_SIZE	256
>  #define RTR_DEFAULT_REFRESH	3600
>  #define RTR_DEFAULT_RETRY	600
>