Index | Thread | Search

From:
Lloyd <ng2d68@proton.me>
Subject:
Re: wg(4) logging enhancement - revised patch
To:
"Kirill A. Korinsky" <kirill@korins.ky>
Cc:
Vitaliy Makkoveev <mvs@openbsd.org>, Vitaliy Makkoveev <otto@bsdbox.dev>, Claudio Jeker <cjeker@diehard.n-r-g.com>, Theo de Raadt <deraadt@openbsd.org>, Stuart Henderson <stu@spacehopper.org>, "tech@openbsd.org" <tech@openbsd.org>
Date:
Thu, 23 Jan 2025 03:33:09 +0000

Download raw body.

Thread 
Kirill A. Korinsky wrote:

> I think you should move a declaration of ipaddr to the begining of the
> functio, to match the style. Like you did it before.

I did this with the intention that not all code paths in those functions
necessitate printing a debug message and thus allocating a buffer.

Is this a false assumption? Will the compiler do whatever it wants with
automatically allocated variables?